-
Notifications
You must be signed in to change notification settings - Fork 8
test: remove redundant test/assertion in HarTest #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove assertGreaterThan sanity check in testSplitLogEntries that validates fixture data rather than testing functionality.
Remove duplicate indices check from testSplitLogEntries since this is already tested by testSplitLogEntriesYieldsWithCorrectIndices.
Remove assertGreaterThan sanity check in testCloneIsDeep that validates fixture data rather than testing functionality.
Remove assertCount(0) assertion in testCloneIsDeep that tests setEntries() side effect rather than cloning behavior.
Remove assertSame('modified-version') assertion in testCloneBrowserIsDeep
that tests setVersion() side effect rather than cloning behavior.
Remove assertGreaterThan sanity check in testSplitLogEntriesYieldsWithCorrectIndices that validates fixture data rather than testing functionality.
Remove assertInstanceOf assertion in testSplitLogEntriesYieldsWithCorrectIndices as the return type is already enforced by the Generator type declaration.
Remove testGetSetLog method entirely as getter/setter coverage is already provided by other tests exercising the Log property.
Remove testSplitLogEntriesYieldsWithCorrectIndices method entirely as the functionality is already covered by testSplitLogEntries.
Remove testCloneIsDeep method entirely as the cloning behavior is already covered by testCloneBrowserIsDeep and testSplitLogEntries.
Remove assertCount($originalEntryCount, $splitHars) assertion in testSplitLogEntries as the count is implicitly verified by iterating through all entries.
Remove assertCount(1, $splitHar->getLog()->getEntries()) assertion from testSplitLogEntries as the entry count is implicitly verified by the fixture-based tests.
Remove assertNotSame assertion in testCloneBrowserIsDeep as the deep clone behavior is already verified by the subsequent modification test.
a907592 to
4f72682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.