Skip to content

Conversation

@deviantintegral
Copy link
Owner

No description provided.

Remove assertGreaterThan sanity check in testSplitLogEntries that
validates fixture data rather than testing functionality.
Remove duplicate indices check from testSplitLogEntries since this is
already tested by testSplitLogEntriesYieldsWithCorrectIndices.
Remove assertGreaterThan sanity check in testCloneIsDeep that
validates fixture data rather than testing functionality.
Remove assertCount(0) assertion in testCloneIsDeep that tests
setEntries() side effect rather than cloning behavior.
Remove assertSame('modified-version') assertion in testCloneBrowserIsDeep
that tests setVersion() side effect rather than cloning behavior.
Remove assertGreaterThan sanity check in testSplitLogEntriesYieldsWithCorrectIndices
that validates fixture data rather than testing functionality.
Remove assertInstanceOf assertion in testSplitLogEntriesYieldsWithCorrectIndices
as the return type is already enforced by the Generator type declaration.
Remove testGetSetLog method entirely as getter/setter coverage
is already provided by other tests exercising the Log property.
Remove testSplitLogEntriesYieldsWithCorrectIndices method entirely
as the functionality is already covered by testSplitLogEntries.
Remove testCloneIsDeep method entirely as the cloning behavior is
already covered by testCloneBrowserIsDeep and testSplitLogEntries.
Remove assertCount($originalEntryCount, $splitHars) assertion in
testSplitLogEntries as the count is implicitly verified by iterating
through all entries.
Remove assertCount(1, $splitHar->getLog()->getEntries()) assertion
from testSplitLogEntries as the entry count is implicitly verified
by the fixture-based tests.
Remove assertNotSame assertion in testCloneBrowserIsDeep as the deep
clone behavior is already verified by the subsequent modification test.
@deviantintegral deviantintegral force-pushed the claude/cleanup-har-tests-vlmNE branch from a907592 to 4f72682 Compare December 18, 2025 01:02
@deviantintegral deviantintegral marked this pull request as ready for review December 18, 2025 01:03
@deviantintegral deviantintegral merged commit c070617 into main Dec 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants